From 04aff9c1c022e70ec46597bbb48c4ecfd103b50c Mon Sep 17 00:00:00 2001 From: Colin Walters Date: Tue, 2 Oct 2018 11:47:48 -0400 Subject: [PATCH] rofiles-fuse: Improve error message for failure to open root I was debugging some rpm-ostree work and saw: `openat: No such file or directory` and it wasn't immediately obvious it was stderr from `rofiles-fuse`. Use the `err` API which is better in many ways; in this case it automatically prefixes with `argv0`. Closes: #1747 Approved by: jlebon --- src/rofiles-fuse/main.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/rofiles-fuse/main.c b/src/rofiles-fuse/main.c index fd16e29b..4033caa4 100644 --- a/src/rofiles-fuse/main.c +++ b/src/rofiles-fuse/main.c @@ -25,6 +25,7 @@ #include #include #include +#include #include #include #include @@ -628,10 +629,7 @@ rofs_parse_opt (void *data, const char *arg, int key, { basefd = openat (AT_FDCWD, arg, O_RDONLY | O_NONBLOCK | O_DIRECTORY | O_CLOEXEC | O_NOCTTY); if (basefd == -1) - { - perror ("openat"); - exit (EXIT_FAILURE); - } + err (1, "opening rootfs %s", arg); return 0; } else -- 2.30.2